fix: update the publisher batch settings #908
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating the Publish Batch settings to be consistent with the rest of the CPS client libs.
product-auto-label
bot
added
the
api: pubsub
google-cla
bot
added
the
cla: yes
anguillanneuf
suggested changes
Jan 25, 2022
| @@ -655,8 +655,8 @@ public static Builder newBuilder(String topicName) { | |||
|
|
|||
| // Meaningful defaults. | |||
| static final long DEFAULT_ELEMENT_COUNT_THRESHOLD = 100L; | |||
| static final long DEFAULT_REQUEST_BYTES_THRESHOLD = 1000L; // 1 kB | |||
| static final Duration DEFAULT_DELAY_THRESHOLD = Duration.ofMillis(1); | |||
| static final long DEFAULT_REQUEST_BYTES_THRESHOLD = 1L * 1024L * 1024L; // 1 MB | |||
There was a problem hiding this comment.
Should it be 1 * 1000 * 1000? 1 MB as shown in go/cps-libs-defaults
Python just updated the docstring to 1 MB here: googleapis/python-pubsub#572
| static final long DEFAULT_REQUEST_BYTES_THRESHOLD = 1000L; // 1 kB | ||
| static final Duration DEFAULT_DELAY_THRESHOLD = Duration.ofMillis(1); | ||
| static final long DEFAULT_REQUEST_BYTES_THRESHOLD = 1L * 1024L * 1024L; // 1 MB | ||
| static final Duration DEFAULT_DELAY_THRESHOLD = Duration.ofMillis(10); |
There was a problem hiding this comment.
Upon reflection, I think we have to hold off on changing this value until v2.0 of the library. For users who are not hitting the batch size limit, this will represent a ~10x increase in publish latency if they are using the default settings. It will be hard for users to understand where that is coming from in the absence of client-side metrics.
anguillanneuf
added
the
do not merge
|
I am going to close this pull request as kamal mentioned above, we are going to hold off on these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the Publish Batch settings to be consistent with the rest of the CPS client libs.